[DOCS] update docs to look less like vetiver.rstudio.com by isabelizimm · Pull Request #178 · rstudio/vetiver-python · GitHub
Skip to content

[DOCS] update docs to look less like vetiver.rstudio.com#178

Merged
isabelizimm merged 7 commits into
mainfrom
doc-look
May 31, 2023
Merged

[DOCS] update docs to look less like vetiver.rstudio.com#178
isabelizimm merged 7 commits into
mainfrom
doc-look

Conversation

@isabelizimm

Copy link
Copy Markdown
Contributor

After gathering community feedback, we may have made too unified of a look between the Python package docs and vetiver.rstudio.com. This PR is to update the look as well as add in links to the R package docs

@isabelizimm

isabelizimm commented May 18, 2023

Copy link
Copy Markdown
Contributor Author

@juliasilge

Copy link
Copy Markdown
Member

You can see the (minor) changes I made to the R pkgdown site navbar here now: https://rstudio.github.io/vetiver-r/dev/

@isabelizimm

Copy link
Copy Markdown
Contributor Author

HMMMM what is happening in this Docs Check 😩

@has2k1

has2k1 commented May 19, 2023

Copy link
Copy Markdown
Collaborator

HMMMM what is happening in this Docs Check 😩

I think there is a missing secret token.

@isabelizimm

Copy link
Copy Markdown
Contributor Author

HMMMM what is happening in this Docs Check 😩

I think there is a missing secret token.

Yeah, the deployment_id is missing because the docs are breaking upon build (a successful docs build will populate this ID). I had installed off a branch of quartodoc locally and am using some new/not backwards compatible features, so I'll plan to rerun and merge this PR on quartodoc's next release!

@machow

machow commented May 25, 2023

Copy link
Copy Markdown
Contributor

I don't think we were able to locally reproduce this specific error last week when pairing (but were able to generate the site locally), so am a bit stumped on what might be going on. Maybe we can take a pass when pairing on Tues, and try updating all requirements?

@isabelizimm

Copy link
Copy Markdown
Contributor Author

@juliasilge juliasilge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌

Comment thread docs/_quarto.yml Outdated
Comment thread docs/_quarto.yml Outdated
Comment thread docs/_quarto.yml
Comment thread docs/_quarto.yml Outdated
Co-authored-by: Julia Silge <julia.silge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants