fix: should not bundle react by chenjiahan · Pull Request #102 · rstackjs/rstack-doc-ui · GitHub
Skip to content

fix: should not bundle react#102

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-should-not-bundle-react
Jun 7, 2026
Merged

fix: should not bundle react#102
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-should-not-bundle-react

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR fixes the doc-ui library build so React-related subpath imports remain external. The previous exact externals matched react and react-dom, but allowed react-dom/client from the Ant Design wave/render path to be bundled into dist/antd, which could conflict with the consuming site's React version.

Validation

  • pnpm build
  • Verified dist/antd/index.js imports react-dom/client externally and no longer contains inlined react-dom@... version-specific code.

Related Links

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

@chenjiahan chenjiahan merged commit cbb8eb3 into main Jun 7, 2026
6 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/fix-should-not-bundle-react branch June 7, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant