{{ message }}
Repository navigation
Conversation
The watcher goroutine previously polled the event queue every 100ms, so a watch event could be delayed by up to 100ms even when the consumer was already blocked waiting on the channel. Replace the polling loop with a capacity-1 notification channel: putEvent signals it after enqueueing, and sendEvent blocks on it and drains all queued events. Shutdown semantics via the done channel are unchanged. Also add a test asserting an event is delivered within 50ms of a Put.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
watch.go, thesendEventgoroutine polls the event queue withtime.Sleep(100 * time.Millisecond)when it is empty. As a result, an event generated by aPut/Delete/batch commit can sit in the queue for up to 100ms before being sent to the consumer channel, even when the consumer is already blocked waiting.This can be fixed with a capacity-1 notification channel that wakes the sender immediately, keeping the existing shutdown semantics.