{{ message }}
Avoid a crash in iOS 13#200
Merged
Merged
Conversation
…indows array firstObject returns nil if there is none. Using [0] or objectAtIndex:0 will crash if there is no object there
Owner
Contributor
Author
|
Hi Rolandleth, It should't break anything, I tested it on a devices with iOS 9, 10, 12 and iOS 13. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use firstObject instead [0] when accessing the first element of the windows array.
firstObject returns nil if there is none. Using [0] or objectAtIndex:0 will crash if there is no object there.
We received some crashes in iOS 13 when the application tries to access the first object of the windows array. The code tries to mitigate this crash.