{{ message }}
This repository was archived by the owner on Mar 21, 2026. It is now read-only.
Added a parsing step by comma for servers still sending back CSV for …#23
Open
johnrey1 wants to merge 3 commits into
Open
Added a parsing step by comma for servers still sending back CSV for …#23johnrey1 wants to merge 3 commits into
johnrey1 wants to merge 3 commits into
Conversation
coolhome
approved these changes
Dec 14, 2019
rflechner
reviewed
Mar 14, 2020
rflechner
left a comment
rflechner
left a comment
Owner
There was a problem hiding this comment.
Thank for your contrib, could you please add unit tests for this class to avoid any regression ?
They are missing in this project 😄
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…multiple cookies #1
ran into same issue getting back a multi-cookie list where origin server separated by comma.
added a split on comma before the regex step