{{ message }}
Repeat the http request on fail#262
Merged
Merged
Conversation
… is a better design, because Telegram end point sometimes may not respond
JellyBrick
suggested changes
Feb 11, 2023
JellyBrick
left a comment
JellyBrick
left a comment
Contributor
There was a problem hiding this comment.
It seems more like a "hack" than a solution.
Also, I think it's better to leave exception handling to the user.
Contributor
Author
reo7sp
requested changes
Feb 11, 2023
…opmost in the retry loop, enclosing everything
Contributor
Author
JellyBrick
approved these changes
Mar 22, 2023
This was referenced Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using tgbot-cpp in production for half a year, and its most recent execution is already up for 60 days. In order to bring this nice stability, I had to handle periodic outages of network and/or telegram endpoint timeout in a more recoverable way. The thing is currently we throw an exception in case the HTTP request fails. I changed that to repeat request with a timeout until it succeeds. To me it seems a fairly reasonable design, even by default. What do you think?