{{ message }}
Conversation
fregante
commented
Jun 16, 2026
Member
Author
There was a problem hiding this comment.
This was not an "issue" button, it was the "non-legacy" button
|
|
||
| subscriptionButton.after( | ||
| <div className="rgh-status-subscription BtnGroup d-flex width-full"> | ||
| {tooltipped({label: 'Unsubscribe', direction: 'sw'}, <SubButton |
Member
Author
There was a problem hiding this comment.
Copilot made a mess in #9451, I cleaned it up and used dprint
| subscriptionButton.after( | ||
| <div className="rgh-status-subscription BtnGroup d-flex width-full"> | ||
| {tooltipped({label: 'Unsubscribe', direction: 'sw'}, <SubButton | ||
| // @ts-expect-error I don't remember how to fix this |
fregante
commented
Jun 16, 2026
| await updateIssueSubscriptionStatus('all', issue); | ||
| void addButtonIssue(subscriptionButton); | ||
| }} | ||
| {...(status === 'all' && disableAttributes)} |
Member
Author
There was a problem hiding this comment.
I also fed it to Claude to reduce duplication a bit and cleanup the feature. Still appears to work on both issues and PRs
fregante
commented
Jun 16, 2026
Comment on lines
+63
to
+80
Member
Author
There was a problem hiding this comment.
Lines got a bit longer but it's way more readable now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
status-subscriptiondisable while loading #9529Test URLs
#9529
Screenshot