{{ message }}
Meta: Add more tooltips with shortcuts#9738
Merged
Merged
Conversation
fregante
commented
Jun 15, 2026
fregante
commented
Jun 15, 2026
| },{ | ||
| message: 'JSX elements with `data-hotkey` must be wrapped in `tooltipped()`', | ||
| selector: | ||
| 'JSXOpeningElement:not(:has(JSXAttribute[name.name="hidden"])) > JSXAttribute[name.name="data-hotkey"]:not(CallExpression[callee.name="tooltipped"] JSXAttribute[name.name="data-hotkey"])', |
Member
Author
There was a problem hiding this comment.
One requires tooltipped as a parent, the other blocks title/aria-label specifically. The previous Program:has() selector did not work and is not supported by eslint.
Does not apply to addTooltip because we already specifically ask not to use addTooltip with JSX
refined-github/source/helpers/tooltip.tsx
Lines 92 to 94 in 76013f5
fregante
commented
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll also consider undoing #9451 partially since
aria-labelis lighter thantooltipped()and is preferable in cases where there's no hotkey/focus/overlap issues.