{{ message }}
Repository navigation
conversation-activity-filter - Turn into svelte component - #9675
Merged
Merged
Conversation
fregante
requested changes
Jun 2, 2026
Member
fregante
changed the title
conversation-activity-filter - Turn into svelte component
fregante
marked this pull request as ready for review
June 2, 2026 06:36
fregante
approved these changes
Jun 2, 2026
fregante
left a comment
fregante
left a comment
Member
There was a problem hiding this comment.
Surprisingly... it works! Not excited by the extra lines, extra files, and :global() selectors, but I think it's worth it.
fregante
reviewed
Jun 2, 2026
Member
|
😍 
In the last copilot commit I took advantage of Svelte, which let me skip the raw CSS and related classes altogether. This sort of diff, paired with the readability of the resulting code, further justifies using svelte components. The drawback is that this PR adds about 4KB to the final bundle. It's unfortunate that JSX is more efficient than Svelte in this regard. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.