`release-download-count` - Prevent hash from being clipped by kidonng · Pull Request #9650 · refined-github/refined-github · GitHub
Skip to content

release-download-count - Prevent hash from being clipped#9650

Merged
kidonng merged 1 commit into
mainfrom
fix/release-download-count
Jun 1, 2026
Merged

release-download-count - Prevent hash from being clipped#9650
kidonng merged 1 commit into
mainfrom
fix/release-download-count

Conversation

@kidonng

@kidonng kidonng commented May 31, 2026

Copy link
Copy Markdown
Member

Fix #9638

Test URLs

https://github.com/cli/cli/releases

Screenshot

Screen.Recording.2026-05-31.at.6.59.42.PM.mov

@kidonng kidonng added the bug label May 31, 2026
kidonng
kidonng commented May 31, 2026
View reviewed changes
Comment thread source/features/release-download-count.tsx

@kidonng kidonng May 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100 chose arbitrarily, but it is close to how it shows on my monitor without the change:

Image

@kidonng

kidonng commented May 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Meta: is this count expected to not exclude PRs?

Screenshot 2026-05-31 at 7 08 02 PM

refined-github/source/helpers/rgh-links.tsx

Lines 24 to 29 in 022ef03

export function getFeatureRelatedIssuesQuery(id: string): string {
const oldNames = getOldFeatureNames(id);
const searchTerms = [id, ...oldNames].map(name => `"${name}"`);
const joinedTerms = searchTerms.length > 1 ? `(${searchTerms.join(' OR ')})` : searchTerms[0];
return `is:open ${joinedTerms}`;
}

@fregante

fregante commented May 31, 2026

Copy link
Copy Markdown
Member

Meta: is this count expected to not exclude PRs?

Correct. The "Related issue" link by rgh-feature-descriptions included all since the very first iteration:

refined-github/source/features/rgh-feature-descriptions.tsx

Line 95 in b012633

const conversationsUrl = '/sindresorhus/refined-github/issues?q=' + encodeURIComponent(`"${feature.id}" sort:updated-desc`);

This number is used on that link too. So it's not strictly "issues". Technically the number also includes any open. issues and PRs that just mention a feature. For example rgh-feature-descriptions shows a number 2 because I mentioned it here.

In short: it's a rough number.

@kidonng kidonng merged commit 6d847ce into main Jun 1, 2026
14 checks passed
@kidonng kidonng deleted the fix/release-download-count branch June 1, 2026 10:38
@Vangelis66

Vangelis66 commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown

I want to report a minor regression, though 😉 ...

Browser is Fx-140esr, with the Bookmarks Sidebar open on the left; test URL:
https://github.com/gorhill/uBlock/releases

Below, prior to #9650 having been merged:

good1

No asset hash column visible, but the download count clearly is...

Now, after #9650 having been merged:

bad1

We now have the asset hash column, but the actual download count of one of the assets overlaps with the asset's (longer) filename 😜 ; granted, this is an edge case, but it still is a regression for me 😄 ...

Kind regards.

Later addition:

I stumbled on yet another "edge" (?) case:

https://github.com/violentmonkey/violentmonkey/releases

bad2

@fregante

fregante commented Jun 1, 2026

Copy link
Copy Markdown
Member

It's been a while since I've seen any overlaps in the area, I fix that a long time ago. Would be good to look for that PR and find out how it used to behave before GitHub broke it in #9638

@fregante

fregante commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

The PR was #8742. By the look of #8637, the SHA should just be hidden on tighter screens instead.

@Vangelis66

Vangelis66 commented Jun 1, 2026

Copy link
Copy Markdown

@fregante fregante mentioned this pull request Jun 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

release-download-count clips the sha at some resolutions

3 participants

@kidonng @fregante @Vangelis66