`sort-conversations-by-update-time` - Don't break label list by Copilot · Pull Request #9606 · refined-github/refined-github · GitHub
Skip to content

sort-conversations-by-update-time - Don't break label list#9606

Merged
fregante merged 3 commits into
mainfrom
copilot/fix-issue-labels-sorting
May 25, 2026
Merged

sort-conversations-by-update-time - Don't break label list#9606
fregante merged 3 commits into
mainfrom
copilot/fix-issue-labels-sorting

Conversation

Copilot AI commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The sort-conversations-by-update-time feature was treating /:owner/:repo/issues/labels as an issue search URL and appending a sort query to the “Edit labels” link in the issue sidebar. This change narrows that detection so the labels settings page is ignored altogether.

  • Selector fix

    • Exclude /issues/labels from the shared conversation-list link selector used by sort-conversations-by-update-time
    • Preserve existing behavior for actual conversation lists like /issues, /pulls, and /labels/:label

  • Regression coverage

    • Add a focused selector test that verifies:
      • /issues/labels does not match
      • /issues still matches
      • /labels/bug still matches
a:is(
	[href*="/issues"],
	[href*="/pulls"],
	[href*="/projects"],
	[href*="/labels/"]
):not(
	[href*="/issues/labels"]
)

Test URLs

Screenshot

Copilot AI linked an issue May 25, 2026 that may be closed by this pull request
sort-conversations-by-update-time breaks /:user/:repo/issues/labels links #9605
Closed
1 task
Copilot AI changed the title [WIP] Fix sorting issue in labels page Ignore /issues/labels in conversation list sorting May 25, 2026
Copilot AI requested a review from fregante May 25, 2026 06:46
@github-actions github-actions Bot added the bug label May 25, 2026
@fregante fregante marked this pull request as ready for review May 25, 2026 06:54
fregante
fregante approved these changes May 25, 2026
View reviewed changes

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better than what I thought. SearchQuery should not receive this type of link in the first place

@fregante fregante changed the title Ignore /issues/labels in conversation list sorting sort-conversations-by-update-time - Don't break label list May 25, 2026
@fregante fregante merged commit 76da456 into main May 25, 2026
18 checks passed
@fregante fregante deleted the copilot/fix-issue-labels-sorting branch June 1, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@fregante fregante fregante approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fregante fregante

Copilot code review Copilot

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sort-conversations-by-update-time breaks /:user/:repo/issues/labels links

2 participants

@fregante