conversation-authors - Fix color for Enterprise#9560
Conversation
| fuchsia | ||
| ) !important; /* Their :hover uses !important... */ | ||
| background-color: var(--bgColor-attention-muted, fuchsia); | ||
| background-color: var(--bgColor-attention-muted, var(--color-attension-subtle, fuchsia)); |
There was a problem hiding this comment.
There are a couple of issues. The class name appears to be misspelled. And you're using a version that is way past our support window
There was a problem hiding this comment.
OK, then I'll just use custom css! thanks!
There was a problem hiding this comment.
We can probably still merge it since I saw we have a number of similar vars and no rush to drop them
There was a problem hiding this comment.
I think so too! It's very safe and there's no risk. 😀
|
This version isn't supported by GitHub since 2025 😭 https://docs.github.com/en/enterprise-server@3.21/admin/all-releases |
|
To maintainers: Please add labels to this PR |
|
We were supposed to drop these a long time ago: In reality I see The only problem with keeping them around is that effectively we don't know if the primary color variables are being matched at all. Once we drop these classes, we might end up with |
3 participants
bgColorvariable.--color-*variables as a replacement, and this CSS follows suit.Test URLs
Screenshot