{{ message }}
linkify-line-numbers - Fix occasional layout break#9532
Merged
Conversation
fregante
reviewed
May 19, 2026
SunsetTechuila
commented
May 19, 2026
Contributor
Author
There was a problem hiding this comment.
Element with the empty-cell class can also have the blob-num class, which sets the cursor to pointer. Having cursor: pointer on a non-interactive element doesn't make sense.
Contributor
Author
fregante
approved these changes
May 19, 2026
fregante
left a comment
fregante
left a comment
Member
There was a problem hiding this comment.
I'm ok with the delegate + onAlteredClick combo for now. If we need more of such features, we should reorganize onAlteredClick to also handle non-altered clicks (in a separate helper).
The helper should probably be called linkify(element, callback), where the callback returns the URL to open in the current tab or in another tab, depending on alteredness
Anyway, future PR, this one is good to go.
fregante
reviewed
May 19, 2026
fregante
reviewed
May 19, 2026
Co-authored-by: fregante <me@fregante.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9511
Closes #9531
Test URLs
#9510 (review)
Screenshot