{{ message }}
closing-remarks - Prevent removal by GitHub #9498
Merged
Merged
Conversation
fregante
commented
May 17, 2026
Member
Author
There was a problem hiding this comment.
This is the fix.
The code is awkward because it's backwards. Normally:
- observe -> rest of the feature logic
This feature:
- feature logic -> observe just to append
A full refactor would be beneficial, but closing-remarks is kinda on life support in the hope that GitHub implements it natively.
| before: () => ( | ||
| // Use observer because GitHub might remove the box | ||
| // https://github.com/refined-github/refined-github/issues/9460 | ||
| observe(commentBoxHashPr, anchor => { |
Member
Author
There was a problem hiding this comment.
This is for the "Not yet release, release now" banner. Not sure if it's affected too, but might as well just drop attachEvent here as well.
Member
Author
There was a problem hiding this comment.
Also tested and it still works:
Member
Author
There was a problem hiding this comment.
The rest of the changes just clarify code a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closing-remarksremoved by GitHub after being added #9460Test URLs
#9418
Screenshot
Video of me refreshing the page while holding
cmddownto scroll to the bottomScreen.Recording.mov