`rgh-feature-descriptions` - Mark removed features as such by Copilot · Pull Request #9412 · refined-github/refined-github · GitHub
Skip to content

rgh-feature-descriptions - Mark removed features as such#9412

Merged
fregante merged 11 commits into
mainfrom
copilot/fix-widget-name-metadata
May 10, 2026
Merged

rgh-feature-descriptions - Mark removed features as such#9412
fregante merged 11 commits into
mainfrom
copilot/fix-widget-name-metadata

Conversation

Copilot AI commented May 10, 2026 •
edited by fregante
Loading

Copy link
Copy Markdown
Contributor

Copilot AI linked an issue May 10, 2026 that may be closed by this pull request
rgh-feature-descriptions appear in incorrect state on old commits #9400
Closed
1 task
Copilot AI changed the title [WIP] Fix widget to show latest name instead of old name rgh-feature-descriptions appear in incorrect state on old commits May 10, 2026
Copilot AI requested a review from fregante May 10, 2026 08:10
@fregante

fregante commented May 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
Before After
Screenshot 4 Screenshot 5

@fregante fregante added bug and removed bug labels May 10, 2026
@fregante fregante marked this pull request as ready for review May 10, 2026 08:18
@github-actions github-actions Bot added bug meta Related to Refined GitHub itself labels May 10, 2026

Copilot AI commented May 10, 2026

Copy link
Copy Markdown
Contributor Author

@copilot undo all, that's senseless.

The bug is in rgh-feature-description and it has nothing to do with the mentioned features. The renames are already correct, it's just that `rgh-feature-descr...

Done in fd6c75f. I reverted the rename-map/test changes and fixed rgh-feature-descriptions so it uses the resolved latest feature name before widget creation (meta?.id ?? currentFeatureName ?? filename). Screenshot: AI GOT NO EYES.

@fregante

fregante commented May 10, 2026

Copy link
Copy Markdown
Member

@copilot there was a mistake. latest-tag-button no longer exists. When the feature doesn't exist anymore:

  • remove Report bug link
  • add "Feature removed:" before the feature name/title

Copilot AI and others added 4 commits May 10, 2026 08:25
@fregante
Handle removed features in rgh-feature-descriptions UI
1909fec 
Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/0a7a4951-837e-4b89-ad19-ed264d00a8f7

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
@fregante
Clarify removed-feature detection variable naming
71b6b56 
Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/0a7a4951-837e-4b89-ad19-ed264d00a8f7

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
@fregante
Use importedFeatures to detect removed feature pages reliably
6469f8e 
Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/0a7a4951-837e-4b89-ad19-ed264d00a8f7

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
@fregante
Refine removed-feature detection typing and naming
1c614a2 
Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/0a7a4951-837e-4b89-ad19-ed264d00a8f7

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot AI commented May 10, 2026

Copy link
Copy Markdown
Contributor Author

@copilot there was a mistake. latest-tag-button no longer exists. When the feature doesn't exist anymore:

  • remove Report bug link
    ...

Implemented in 1c614a2. Removed features now show Feature removed: before the title and no longer render the Report bug link. Screenshot: AI GOT NO EYES.

@fregante

fregante commented May 10, 2026

Copy link
Copy Markdown
Member

@copilot It's mistakenly marking css-only features as removed. The features don't appear in the featureList array, but exist nonetheless.

Copilot AI changed the title rgh-feature-descriptions appear in incorrect state on old commits rgh-feature-descriptions fix old-commit identity and removed-feature state May 10, 2026
@fregante fregante mentioned this pull request May 10, 2026
Open
@fregante fregante changed the title rgh-feature-descriptions fix old-commit identity and removed-feature state rgh-feature-descriptions - Mark removed features as such May 10, 2026
fregante
fregante approved these changes May 10, 2026
View reviewed changes

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOICE

@fregante

fregante commented May 10, 2026

Copy link
Copy Markdown
Member

@copilot don't make changes other than what's described here. Don't touch the PR body/title

  1. alter addDescription's body exclusively
  2. Use const removedFeature = !description
  3. add {removedFeature && <span className="color-fg-muted">Feature removed: </span>} before <code>{id}</code>
  4. hide Report bug link when the feature is removed

Copilot AI commented May 10, 2026

Copy link
Copy Markdown
Contributor Author

Copilot AI requested a review from fregante May 10, 2026 08:56
@fregante fregante merged commit f6fdd2d into main May 10, 2026
10 checks passed
@fregante fregante deleted the copilot/fix-widget-name-metadata branch May 10, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@fregante fregante fregante approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fregante fregante

Copilot code review Copilot

Labels

bug meta Related to Refined GitHub itself

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rgh-feature-descriptions appear in incorrect state on old commits

2 participants

@fregante