Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
linkify-line-numbers, no-modals - Support middle click
#9354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a199186
`linkify-line-numbers`, `no-modals` - Support middle click
SunsetTechuila 05fa5f9
changes
SunsetTechuila c339866
keep line number color
SunsetTechuila 3f41085
change lineNumberCell type
SunsetTechuila 221f5cf
reorder imports
SunsetTechuila 39cd0c8
use `d-table-cell` class
SunsetTechuila 4f2ead5
minor changes
SunsetTechuila 9d9974a
throw error if `data-line-number` not found
SunsetTechuila 9842495
rename `url` var to `lineUrl`
SunsetTechuila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import type {ParseSelector} from 'typed-query-selector/parser.d.js'; | ||
| import delegate, {type DelegateEventHandler, type DelegateOptions} from 'delegate-it'; | ||
| import {isAlteredClick} from 'filter-altered-clicks'; | ||
|
|
||
| export default function onAlteredClick<Selector extends string>( | ||
| selector: Selector | readonly Selector[], | ||
| callback: DelegateEventHandler<PointerEvent, ParseSelector<Selector>>, | ||
| options?: DelegateOptions, | ||
| ): void { | ||
| const clickListener: typeof callback = event => { | ||
| if (isAlteredClick(event)) { | ||
| callback(event); | ||
| } | ||
| }; | ||
|
|
||
| const auxClickListener: typeof callback = event => { | ||
| // Is middle click | ||
| if (event.button === 1) { | ||
| callback(event); | ||
| } | ||
| }; | ||
|
|
||
| const preventAutoScrolling = (event: MouseEvent): void => { | ||
| event.preventDefault(); | ||
| }; | ||
|
|
||
| delegate(selector, 'click', clickListener, options); | ||
| delegate(selector, 'auxclick', auxClickListener, options); | ||
| delegate(selector, 'mousedown', preventAutoScrolling, {...options, capture: true}); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New selector:
data-line-numberattribute not found