shorten-links - Show "(earlier comment)" for same-thread links#9329
Conversation
Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/2b6d6e96-75e2-4203-8bbd-99497ba003e5 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/178089fe-491d-4b9b-8f4d-697b1fdf3f47 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
fregante
changed the title
shorten-links - Show "(earlier comment)" for same-thread links
Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/d3929279-71cb-4524-9f2d-f99eef0c244a Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
Straightforward, tested, screenshotted, merging
|
comment |
|
"earlier comment" can be factually incorrect: #9329 (review). It's also not immediately clear that the link refers to a comment in the same thread. "Comment on this conversation" would be better, imo |
|
And reviews are not covered: 
|
|
PRs are best reviewed when open, not immediately after closure. |
|
For the order of the comments, I suppose this is likely to happen on issues where generally the first comment will say "Edit: Refer to comment xyz below for the solution". Technically speaking, any links to comments always refer to them in the past. If you edit a comment it always refers to an earlier comment because you cannot link to a comment that doesn't yet exist. We could use "comment on this page" to make it easier but it could be verbose. Do you have any suggestions other than time-based wording? |
Test URLs
#6057 (comment)
#9329 (comment)
Screenshot