{{ message }}
quick-review - Speed up "Files changed" page opening#9259
Merged
Conversation
SunsetTechuila
changed the title
quick-review - Speed up page openingquick-review - Speed up "Files changed" page opening
fregante
reviewed
Apr 24, 2026
Member
Contributor
Author
I decided to use |
SunsetTechuila
commented
Apr 24, 2026
Contributor
Author
|
Check the comparison |
SunsetTechuila
force-pushed
the
quick-review-speed
branch
from
05bf370 to
0dcdd8a
Compare
Member
🏎️💨💨💨💨 |
SunsetTechuila
commented
Apr 24, 2026
| data-hotkey="v" | ||
| aria-label="Hotkey: V" | ||
| onClick={event => { | ||
| event.preventDefault(); // Fix our buttons being removed |
fregante
approved these changes
Apr 25, 2026
fregante
left a comment
fregante
left a comment
Member
There was a problem hiding this comment.
Can be merged if the old UI was tested with the latest commit
Copilot AI
pushed a commit
that referenced
this pull request
Apr 30, 2026
Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
fregante
reviewed
May 9, 2026
Member
There was a problem hiding this comment.
- <a href>
+ <button>Can no longer open in a new tab 🥲
Contributor
Author
There was a problem hiding this comment.
Will address that
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #9258
The problem with the current implementation is that it forces a hard navigation instead of client-side soft navigation (#9192 (comment)), significantly slowing down page loading.
Test URLs
this PR
Screenshot
Before:
After: