`linkify-user-labels` - Expand to PR list by SunsetTechuila · Pull Request #9175 · refined-github/refined-github · GitHub
Skip to content

linkify-user-labels - Expand to PR list#9175

Merged
SunsetTechuila merged 5 commits into
mainfrom
link-label
Apr 15, 2026
Merged

linkify-user-labels - Expand to PR list#9175
SunsetTechuila merged 5 commits into
mainfrom
link-label

Conversation

@SunsetTechuila

@SunsetTechuila SunsetTechuila commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

@SunsetTechuila

SunsetTechuila commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

fregante
fregante reviewed Apr 10, 2026
View reviewed changes

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't find this particularly useful but it's ok if you want to add it

Comment thread source/features/linkify-user-labels.tsx Outdated
@SunsetTechuila SunsetTechuila marked this pull request as draft April 10, 2026 15:39
@SunsetTechuila SunsetTechuila marked this pull request as ready for review April 10, 2026 16:14
fregante
fregante reviewed Apr 14, 2026
View reviewed changes
Comment thread source/features/linkify-user-labels.tsx Outdated

@fregante fregante Apr 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not confident about this one, I think we can use our SearchQuery utility to parse it, but it will be probably 2/3 lines longer.

It can stay as is if you prefer it

@SunsetTechuila SunsetTechuila Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am

@SunsetTechuila SunsetTechuila Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link somewhat respects only the state-related (is:open/state:open) query parameters

@SunsetTechuila SunsetTechuila Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is always either:

  • is:pr author:author
  • is:pr is:open author:author (can't be even is:closed)

@fregante fregante Apr 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question then is why is this link not affected by our "sort by update time" feature?

@SunsetTechuila SunsetTechuila Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links on issue lists respect the current query and still end with the author

Comment thread source/features/linkify-user-labels.tsx Outdated
@SunsetTechuila SunsetTechuila merged commit 5d588a0 into main Apr 15, 2026
9 checks passed
@SunsetTechuila SunsetTechuila deleted the link-label branch April 15, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SunsetTechuila @fregante