{{ message }}
Conversation
SunsetTechuila
changed the title
more-file-links - Improve accessibilitymore-file-links - Fix accessibility
SunsetTechuila
changed the title
more-file-links - Fix accessibilitymore-file-links, restore-file - Fix accessibility
Contributor
Author
|
is it time to add a helper? |
SunsetTechuila
commented
Mar 20, 2026
Member
|
Not sure why this is needed. The label is there because there's an attribute pointing to it. Just removing it should be enough, particularly because it's redundant with the comment itself. Worst case scenario you remove that "described by" and add "aria-label" |
fregante
reviewed
Mar 20, 2026
fregante
reviewed
Mar 20, 2026
Contributor
Author
fregante
approved these changes
Mar 20, 2026
fregante
left a comment
fregante
left a comment
Member
There was a problem hiding this comment.
Unfortunately we can't really use GitHub as a base for good code 🥲
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test URLs
https://github.com/refined-github/sandbox/pull/16/changes
Screenshot