`clean-conversation-headers` - Fix PR summary row position on small screens by SunsetTechuila · Pull Request #9079 · refined-github/refined-github · GitHub
Skip to content

clean-conversation-headers - Fix PR summary row position on small screens#9079

Merged
SunsetTechuila merged 1 commit into
mainfrom
clean-headers-aligment
Mar 13, 2026
Merged

clean-conversation-headers - Fix PR summary row position on small screens#9079
SunsetTechuila merged 1 commit into
mainfrom
clean-headers-aligment

Conversation

@SunsetTechuila

Copy link
Copy Markdown
Contributor

This creates a misalignment:

image

However, I think it's a minor issue compared to the current one. Plus, GitHub is to blame for it, not us

Test URLs

#9067

Screenshot

Before After
image image

@SunsetTechuila

Copy link
Copy Markdown
Contributor Author

We can play with the styles later, after we drop support for the old header

@SunsetTechuila SunsetTechuila changed the title clean-conversation-headers - Fix PR metadata row position on small screens clean-conversation-headers - Fix PR summary row position on small screens Mar 11, 2026
@SunsetTechuila

Copy link
Copy Markdown
Contributor Author

Let's rename the feature to clean-pr-header

image

@fregante

Copy link
Copy Markdown
Member

Renames have been limited for a while unless very necessary. They generally add a lot of noise and break search.

In this case I don't exclude we'll restore issue cleaning once they stop playing with that piece of UI

@fregante

Copy link
Copy Markdown
Member

But yeah feel free to drop support in this PR, it's not a fundamental feature, just a minor cleanup.

@fregante

Copy link
Copy Markdown
Member

in this PR

Because it presumably causes some visual misalignment/issue in the old view, which we can't test and it's best we just drop support for altogether.

@SunsetTechuila

Copy link
Copy Markdown
Contributor Author

@SunsetTechuila SunsetTechuila merged commit d55ce3b into main Mar 13, 2026
14 checks passed
@SunsetTechuila SunsetTechuila deleted the clean-headers-aligment branch March 13, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants