{{ message }}
no-self-reference - Fix false positives on AJAX navigation#9078
Closed
scarf005 wants to merge 2 commits into
Closed
Conversation
…igation Compare issue links against the current page at callback time so Turbo page replacement no longer reuses an outdated URL and disables the wrong link. Refs: refined-github#9077 Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Assisted-by: openai/gpt-5.4 on opencode
scarf005
changed the title
no-self-reference - Fix false positives after Turbo issue navigation (#9077)
fregante
approved these changes
Mar 12, 2026
fregante
changed the title
no-self-reference - Fix false positives after Turbo issue navigation (#9077)no-self-reference - Fix false positives on AJAX navigation
Member
There was a problem hiding this comment.
How is this possible? Isn't the code the same as in your PR?
Member
There was a problem hiding this comment.
I think both PRs are discarding the hash, which was not the case before. Only links without hash were being selected by the observer.
Contributor
There was a problem hiding this comment.
Yes, I made the same mistake
Contributor
There was a problem hiding this comment.
Or this mistake of mine made it into both PRs
Member
There was a problem hiding this comment.
I think we should just use :not(href*="#"]) in the selector and then use location.href without .split here.
| const selfLink = { | ||
| href: 'https://github.com/refined-github/refined-github/issues/9077#issuecomment-2', | ||
| }; | ||
| assert.isTrue(isCurrentPageLink(selfLink)); |
Contributor
There was a problem hiding this comment.
That should return false
Contributor
Author
|
@fregante @SunsetTechuila should I close this PR in favor of #9086? |
Contributor
|
No |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9077
Test URLs
http2.createSecureServerfor HTTP/2? expressjs/express#6863Screenshot