{{ message }}
Conversation
fregante
commented
Apr 8, 2025
Member
Author
There was a problem hiding this comment.
The issue was two-fold:
isRepoRootwas wrong due to a change indocument.titleI guess- we treated all URLs with
%2Fas root, which appears to not be the case anymore
Member
Author
There was a problem hiding this comment.
Also fixed the TODO while preserving slashed-branches detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default-branch-button: Button links to repo root #8185previous-version: GraphQL:Something went wrong while executing your query. Please includeCC6E:3A0E74:63D1D1:C7911C:6771F871when reporting this issue. #8184isRepoRootgithub-url-detection#204default-branch-button- Click the button return to repo root #8299Note that
previous-commitstill doesn't work on that page, but that's a separate issue (i.e. the API does not follow file renames, and don't see a way to force it to)Test URLs
https://github.com/typescript-eslint/typescript-eslint/blob/86409083167bee4ba1ad3ebba22785b3a4a262ee/packages%2Feslint-plugin%2Fdocs%2Frules%2Fstrict-boolean-expressions.mdx
Screenshot