`conversation-activity-filter` - Fix sticky header and mobile alignment by digvijay-555 · Pull Request #10228 · refined-github/refined-github · GitHub
Skip to content

conversation-activity-filter - Fix sticky header and mobile alignment #10228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
digvijay-555 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

conversation-activity-filter - Fix sticky header and mobile alignment #10228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions source/features/conversation-activity-filter.css
View file
Open in desktop
9 changes: 1 addition & 8 deletions source/features/conversation-activity-filter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@
} from '../helpers/conversation-activity-filter.js';
import {isSmallDevice} from '../helpers/dom-utils.js';

type Props = {
withMargin?: boolean;
};
const {withMargin = false}: Props = $props();

const baseId = crypto.randomUUID();

function selectState(targetState: State): void {
Expand All @@ -27,9 +22,7 @@
</script>
<action-menu
hidden={!pageDetect.isConversation($url)}
class={`position-relative lh-condensed-ultra v-align-middle ${
withMargin ? 'ml-2' : ''
}`}
class="position-relative lh-condensed-ultra v-align-middle"
data-select-variant="single"
>
<focus-group direction="vertical" mnemonics retain>
Expand Down
9 changes: 6 additions & 3 deletions source/features/conversation-activity-filter.tsx
View file
Open in desktop
Loading