Show number of commits in 'Prev' and 'Next' while in review - #10047
Show number of commits in 'Prev' and 'Next' while in review#10047patrickelectric wants to merge 6 commits into
Conversation
The commits page lists every hash in order, so the counts can be computed without an API token. Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
449108f to
cf4c54b
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
|
Not a bad idea, I like that the feature is somewhat compact and that it only requires one HTTP request (which should cache via CachedFunction for 1 hour by the way) However I'm hesitant to add features for people who don't use Refined GitHub. Any reason why |
🤣 I'm glad of your suspicious. I use refined-github for so long that I don't remember when I started using it (maybe 7/8+ years ?). I tried to collaborate a couple of times, but usually some issues/PR were already proposed and not merged/closed (oh man, #5380 would be so nice! That helps me to sort which PR to review between meetings). Well, for my test I used a temporary profile for development since I don't want to messup with the standard extension, it was just a quick feature to work on after the work. |


Fix #10044
Ok hear me out, this is pretty important!
I need to review big PR's sometimes (Yeah, I'm looking at you @joaoantoniocardoso), and while navigating each commit to review and understand the code, sometimes I have no idea where am I and how much is still left. Sometimes I need to do two cup of coffee to review this kind of PRs! So, it's utterly important for me to have this notion while doing my work, planning what should I do with my life, and navigating this infinity number of commits. Having the number at least give me some hope to see the light in the end of the review process.
Test URLs
You probably need to go in> Commits -> Click in a commit in the middle
mavlink/mavlink-camera-manager@a02ae36
Screenshot