Show number of commits in 'Prev' and 'Next' while in review by patrickelectric · Pull Request #10047 · refined-github/refined-github · GitHub
Skip to content

Show number of commits in 'Prev' and 'Next' while in review - #10047

Open
patrickelectric wants to merge 6 commits into
refined-github:mainfrom
patrickelectric:add-pr-commit-position
Open

Show number of commits in 'Prev' and 'Next' while in review#10047
patrickelectric wants to merge 6 commits into
refined-github:mainfrom
patrickelectric:add-pr-commit-position

Conversation

@patrickelectric

Copy link
Copy Markdown

Fix #10044

Ok hear me out, this is pretty important!
I need to review big PR's sometimes (Yeah, I'm looking at you @joaoantoniocardoso), and while navigating each commit to review and understand the code, sometimes I have no idea where am I and how much is still left. Sometimes I need to do two cup of coffee to review this kind of PRs! So, it's utterly important for me to have this notion while doing my work, planning what should I do with my life, and navigating this infinity number of commits. Having the number at least give me some hope to see the light in the end of the review process.

Test URLs

You probably need to go in> Commits -> Click in a commit in the middle
mavlink/mavlink-camera-manager@a02ae36

Screenshot

image

The commits page lists every hash in order, so the counts can be
computed without an API token.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
patrickelectric marked this pull request as ready for review September 5, 2026 02:17
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@fregante

fregante commented Sep 5, 2026

Copy link
Copy Markdown
Member

Not a bad idea, I like that the feature is somewhat compact and that it only requires one HTTP request (which should cache via CachedFunction for 1 hour by the way)

However I'm hesitant to add features for people who don't use Refined GitHub. Any reason why prevent-link-loss wasn't used?

@patrickelectric

Copy link
Copy Markdown
Author

Not a bad idea, I like that the feature is somewhat compact and that it only requires one HTTP request (which should cache via CachedFunction for 1 hour by the way)

However I'm hesitant to add features for people who don't use Refined GitHub. Any reason why prevent-link-loss2 wasn't used?

🤣

I'm glad of your suspicious. I use refined-github for so long that I don't remember when I started using it (maybe 7/8+ years ?). I tried to collaborate a couple of times, but usually some issues/PR were already proposed and not merged/closed (oh man, #5380 would be so nice! That helps me to sort which PR to review between meetings).

Well, for my test I used a temporary profile for development since I don't want to messup with the standard extension, it was just a quick feature to work on after the work.

google-chrome-stable \
  --user-data-dir=/tmp/potato \
  --load-extension=/home/patrick/git/patrick/refined-github/distribution

@patrickelectric

Copy link
Copy Markdown
Author

oh sorry, are you talking about this ?

image

I thought that was github alarming me that I posted a link from a link-from-review-commit-pr or something that would not work if someone reworks the PR. I was not aware that was a refined-github feature.

@fregante

fregante commented Sep 5, 2026

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Add number of commits in review process (prev/next buttons)

2 participants