{{ message }}
netiquette - Ignore null close dates - #10045
Open
moraesc wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65c6c9b6-28e5-448a-a6cf-f4ac05df99c9
fregante
reviewed
Sep 5, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65c6c9b6-28e5-448a-a6cf-f4ac05df99c9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10022
The page can identify a conversation as closed while the Issues API response still has
closed_at: null, such as during a state transition.assertDefinedpermitsnull, so the value was passed tonew Date(null)and became the Unix epoch. Thetwasformatter then displayed that date as "58 years ago."Ignore the null API value instead of rendering a misleading banner, and cover both valid and null close dates with unit tests.
Test URLs
#10022
Screenshot