{{ message }}
clean-readme-url - Fix Readme sidebar link - #10035
Closed
wakamex wants to merge 1 commit into
Closed
Conversation
wakamex
marked this pull request as ready for review
September 3, 2026 22:35
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #10030
I kept GitHub's
#readme-ov-filelink unchanged. It looks like a broken anchor while README is already selected, but GitHub also uses it to switch from License, Contributing, Security, and other overview tabs back to README. This matches the original reproduction in #6904 and the tab behavior described in #8370 (comment).The fix adds a real
#readmetarget when the asynchronously rendered repository-files navigation appears, plus a click fallback that scrolls without preventing GitHub's tab handler. After GitHub selects README, the existing cleaner still removes only the redundant?tab=readme-ov-fileparameter and corrects the final scroll position. Other?tab=…-ov-fileURLs remain untouched.I tested removing the existing 500 ms delay separately. The correct tab was selected, but the target finished 111 px too low in Chrome and 202 px too low in Firefox, so this keeps the delay.
Tested in Chrome 151 and Firefox 154:
#readmeURLnpm test: 564 passed, 28 skipped.Test URLs