Add Windows runners compatibility by b0bben · Pull Request #30 · reecetech/version-increment · GitHub
Skip to content

Add Windows runners compatibility#30

Merged
ps-jay merged 13 commits into
reecetech:mainfrom
b0bben:action-path-lookup-windows
Apr 24, 2024
Merged

Add Windows runners compatibility#30
ps-jay merged 13 commits into
reecetech:mainfrom
b0bben:action-path-lookup-windows

Conversation

@b0bben

@b0bben b0bben commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

This PR does 2 things to make this awesome action work on Windows runners:

All tests are passing on my Windows + macOS self-hosted runners.

@ps-jay ps-jay force-pushed the action-path-lookup-windows branch from f931b76 to 1926371 Compare April 24, 2024 02:12
ps-jay added 2 commits April 24, 2024 12:25
- Message is using a variable that's not confirmed as set yet
- Message is output by `version-lookup.sh` in normal operation anyway

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Comment thread shared.sh
set -euo pipefail

# Force UTF-8 for all commands, for Git-Bash on Windows compatibility
export LC_ALL=C.UTF-8

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perl on MacOS doesn't like this - it emits some warnings ... but I think it's okay if all the tests pass anyway! 😈

@ps-jay ps-jay force-pushed the action-path-lookup-windows branch from d284b63 to 16351e1 Compare April 24, 2024 02:29
@ps-jay ps-jay force-pushed the action-path-lookup-windows branch from ec1c394 to 8df12f2 Compare April 24, 2024 02:35
@ps-jay

ps-jay commented Apr 24, 2024

Copy link
Copy Markdown
Member

@ps-jay ps-jay merged commit dee3ec8 into reecetech:main Apr 24, 2024
cgrindel-self-hosted-renovate Bot referenced this pull request in cgrindel/renovate-bot Apr 24, 2024
…145)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[reecetech/version-increment](https://togithub.com/reecetech/version-increment)
| action | patch | `2024.4.1` -> `2024.4.3` |

---

### Release Notes

<details>
<summary>reecetech/version-increment
(reecetech/version-increment)</summary>

###
[`v2024.4.3`](https://togithub.com/reecetech/version-increment/releases/tag/2024.4.3)

[Compare
Source](https://togithub.com/reecetech/version-increment/compare/2024.4.2...2024.4.3)

#### What's Changed

- Add Windows runners compatibility by
[@&#8203;b0bben](https://togithub.com/b0bben) in
[https://github.com/reecetech/version-increment/pull/30](https://togithub.com/reecetech/version-increment/pull/30)

#### New Contributors

- [@&#8203;b0bben](https://togithub.com/b0bben) made their first
contribution in
[https://github.com/reecetech/version-increment/pull/30](https://togithub.com/reecetech/version-increment/pull/30)

**Full Changelog**:
reecetech/version-increment@2024.4.2...2024.4.3

###
[`v2024.4.2`](https://togithub.com/reecetech/version-increment/releases/tag/2024.4.2)

[Compare
Source](https://togithub.com/reecetech/version-increment/compare/2024.4.1...2024.4.2)

#### What's Changed

- Add multi-OS testing (`ubuntu` & `macos` for now); Rework MacOS
support to use `perl` by [@&#8203;ps-jay](https://togithub.com/ps-jay)
in
[https://github.com/reecetech/version-increment/pull/32](https://togithub.com/reecetech/version-increment/pull/32)

**Full Changelog**:
reecetech/version-increment@2024.4.1...2024.4.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants