{{ message }}
Repository navigation
Conversation
Fix lua to string exposing heap addresses space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent Lua’s default
tostringfrom exposing process memory addresses. Object values now return strings such astable: <opaque>andfunction: <opaque>.Behavior
__tostringbehavior.Testing
(cherry picked from commit 3d18eb1b71daa112918a312fc7a4b9b36677dce0)
Note
Medium Risk
Changes observable Lua
tostringoutput in the scripting sandbox (security hardening); behavior is narrow and covered by new tests but may affect scripts that relied on pointer strings.Overview
Hardens the embedded Lua sandbox by changing default
tostringfor non-scalar values (tables, functions, threads, userdata, etc.) fromtype: 0x…totype: <opaque>, so EVAL/Redis Functions scripts cannot read process heap addresses.Scalar
tostringbehavior and custom__tostringmetamethods are unchanged. Regression tests inscripting.tclcover opaque output for common object types, scalar conversions, metamethod success/errors, andnewproxyuserdata whenlua-enable-deprecated-apiis enabled.Reviewed by Cursor Bugbot for commit 29dd0da. Bugbot is set up for automated code reviews on this repo. Configure here.