{{ message }}
Open
Conversation
leibale
reviewed
Jun 27, 2023
Contributor
leibale
left a comment
leibale
left a comment
There was a problem hiding this comment.
Overall looks good, some small changes are needed..
Thanks for contributing!
| wait: WAIT | ||
| wait: WAIT, | ||
| WAITAOF, | ||
| waitaof: WAITAOF |
Contributor
There was a problem hiding this comment.
Change to waitAOF or waitAof (I'm actually not sure which one we should go with :P)
| [1, 0] | ||
| ); | ||
| }, GLOBAL.SERVERS.OPEN); | ||
| }); No newline at end of file |
| ]; | ||
| } | ||
|
|
||
| export declare function transformReply(): Array<[number, number]>; No newline at end of file |
Contributor
Author
|
@leibale Thanks for reviewing! I make some changes according to your feedback. Please take a look whenever you have time. |
leibale
changed the title
WAITAOF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #2458
Checklist
npm testpass with this change (including linting)?