Feat/chart repo pr action by deweya · Pull Request #32 · redhat-cop/github-actions · GitHub
Skip to content

Feat/chart repo pr action#32

Merged
sabre1041 merged 4 commits into
redhat-cop:masterfrom
deweya:feat/chart-repo-pr-action
Oct 24, 2020
Merged

Feat/chart repo pr action#32
sabre1041 merged 4 commits into
redhat-cop:masterfrom
deweya:feat/chart-repo-pr-action

Conversation

@deweya

@deweya deweya commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

What is this PR About?

This is the GH Action that I shared on the container CoP call this morning. It was originally at https://github.com/deweya/chart-repo-pr-action, but I'd like to move it here since I think it will benefit CoP projects that want to publish their Helm charts but also want to maintain them separately from a central chart repository.

How do we test this?

I originally had a detailed workflow in my personal repo. I'd like to carry this over too, but it requires a personal access token that can push to the fork of the desired Helm repository. This token must be configured as a secret (settings->secrets) so that test workflow has permission to push to the fork (without exposing the token, of course).

Can a maintainer of this repo create an access token with at least these permissions so that I can copy over my automated tests?

  • public_repo
  • read:discussion

Once created, can you add the access token as a secret to this repo?

Additional Details

My design requires users to create a fork of the target Helm chart repository. However, as I'm writing this, I realize that the chart repo might be under redhat-cop, along with other projects that might use this action. This makes creating a fork unreasonable, since you can't fork under the same org.

Is this correct to assume? Technically, with this action you don't need to fork, but the UX is bad since I wrote it with that requirement in mind. Let me know, and I can adjust accordingly.

cc: @redhat-cop/github-actions

@sabre1041 sabre1041 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments added. Looks good, but need to rebase on RH UBI image

Comment thread chart-repo-pr-action/Dockerfile Outdated
@deweya

deweya commented Oct 4, 2020

Copy link
Copy Markdown
Contributor Author

@deweya

deweya commented Oct 9, 2020

Copy link
Copy Markdown
Contributor Author

@sabre1041 Any updates on this PR?

@deweya

deweya commented Oct 12, 2020

Copy link
Copy Markdown
Contributor Author

@sabre1041 sabre1041 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041 sabre1041 merged commit 8fab873 into redhat-cop:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants