{{ message }}
Add slimmed-down Selenium project code#596
Merged
brendaweles merged 26 commits intomasterfrom Apr 22, 2025
Merged
Conversation
Contributor
Author
bzaczynski
reviewed
Oct 23, 2024
bzaczynski
reviewed
Oct 23, 2024
bzaczynski
requested changes
Oct 23, 2024
Contributor
bzaczynski
left a comment
There was a problem hiding this comment.
@martin-martin I left a few comments for you. Let me know what you think.
Co-authored-by: Bartosz <bartosz.zaczynski@gmail.com>
…ials into python-selenium
bzaczynski
approved these changes
Oct 28, 2024
Contributor
bzaczynski
left a comment
There was a problem hiding this comment.
@martin-martin Perfecto ✨ Thanks for a quick update! Can't wait to review the rest of it 😉
Bandcamp removed the "Discover" section from their main page since we wrote this code. Now, the tracks are only available at the dedicated /discover URL. I restructured the code to target the /discover site instead, which required a couple of changes. Still, the existing POM structure was helpful :) I also (re)introduced a new "pause" option, because that's a bit easier in this new structure. Finally, I only allow loading more songs once, which gives a total of 120 songs to pick from with the default screen setting. Attempting to load more resulted in errors, I think because they'd be outside of the viewport and I didn't want to expand the code more and introduce scrolling more of them into view. Also, not sure whether that'd take earlier ones out of the viewport (etc) so I just decided not to open that can of worms for this "Intro to Selenium" tutorial. LMK if you disagree, otherwise of course you can tackle that in your longer one that builds on top of this one :)
Co-authored-by: Bartosz <bartosz.zaczynski@gmail.com>
bzaczynski
reviewed
Mar 16, 2025
Contributor
bzaczynski
left a comment
There was a problem hiding this comment.
@martin-martin Hi Martin!
The code looks great overall. I only left a few minor comments for your consideration, but no explicit requests for change.
Take care!
Co-authored-by: Bartosz <bartosz.zaczynski@gmail.com>
Co-authored-by: Bartosz <bartosz.zaczynski@gmail.com>
brendaweles
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Where to put new files:
my-awesome-articleHow to merge your changes: