Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add prefer_scaled_to_fit opt-in rule#6609
Draft
DemiDevv wants to merge 3 commits intorealm:mainrealm/SwiftLint:mainfrom
DemiDevv:demidev/prefer-scaled-to-fitDemiDevv/SwiftLint:demidev/prefer-scaled-to-fitCopy head branch name to clipboard
Draft
Add prefer_scaled_to_fit opt-in rule#6609DemiDevv wants to merge 3 commits intorealm:mainrealm/SwiftLint:mainfrom DemiDevv:demidev/prefer-scaled-to-fitDemiDevv/SwiftLint:demidev/prefer-scaled-to-fitCopy head branch name to clipboard
prefer_scaled_to_fit opt-in rule#6609DemiDevv wants to merge 3 commits intorealm:mainrealm/SwiftLint:mainfrom
DemiDevv:demidev/prefer-scaled-to-fitDemiDevv/SwiftLint:demidev/prefer-scaled-to-fitCopy head branch name to clipboard
Conversation
Generated by 🚫 Danger |
Author
|
@SimplyDanny It seems like some CI checks are stuck in "Waiting for status to be reported" for a while. Is there anything I need to do on my end, or is this expected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.

Closes #5713
Adds a new opt-in rule
prefer_scaled_to_fitthat suggests usingscaledToFit()orscaledToFill()instead ofaspectRatio(contentMode:)when the content mode is a constant(
.fitor.fill).As noted in Apple's documentation,
scaledToFit()is equivalent toaspectRatio(nil, contentMode: .fit), so the shorter form ispreferred when no custom aspect ratio is provided.