{{ message }}
Add defc macro to create fn components with Fast Refresh support#598
Draft
Deraen wants to merge 2 commits into
Draft
Add defc macro to create fn components with Fast Refresh support#598Deraen wants to merge 2 commits into
Deraen wants to merge 2 commits into
Conversation
fc86c2a to
6307cc3
Compare
Member
Author
roman01la
reviewed
Dec 8, 2023
| - Call `reagent.dev/refresh!` instead | ||
| - Only components defined using `r/defc` will refresh | ||
| - Reagent doesn't try to create Hook signatures for components, | ||
| so hook state is reset for updated components. |
There was a problem hiding this comment.
I’m curious, if local state will be reset, what’s the motivation to enable react refresh in Reagent?
Member
Author
There was a problem hiding this comment.
To help projects using both Reagent and UIx/Helix, so they can enable it and get benefit on React Refresh for UIx/Helix components.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Investigating if React Refresh support is possible in some way. It will require using a macro, because attaching necessary data to the function (component) just isn't possible when components are created when rendering Hiccup forms (what Reagent normally does.)
:f>defccomponent also! No need to convert everything to use the macro?forceResetflag cause re-mount always? If so, we might HAVE to create correct signatures to keep state for even UIx components in component tree?TODO: