reactphp · jsor · Jan 5, 2018 · Jan 4, 2018 · Jan 5, 2018
diff --git a/README.md b/README.md
@@ -1359,6 +1359,14 @@ To run the test suite, go to the project root and run:
 $ php vendor/bin/phpunit
 ```
 
+The test suite also contains a number of functional integration tests that rely
+on a stable internet connection.
+If you do not want to run these, they can simply be skipped like this:
+
+```bash
+$ php vendor/bin/phpunit --exclude-group internet
+```
+
 ## License
 
 MIT, see [LICENSE file](LICENSE).
diff --git a/tests/IntegrationTest.php b/tests/IntegrationTest.php
@@ -10,6 +10,7 @@
 use React\Socket\SecureConnector;
 use React\Socket\TcpConnector;
 
+/** @group internet */
 class IntegrationTest extends TestCase
 {
     const TIMEOUT = 5.0;
@@ -167,20 +168,4 @@ public function testSelfSignedResolvesIfVerificationIsDisabled()
         // if we reach this, then everything is good
         $this->assertNull(null);
     }
-
-    public function testCancelPendingConnection()
-    {
-        $loop = Factory::create();
-
-        $connector = new TcpConnector($loop);
-        $pending = $connector->connect('8.8.8.8:80');
-
-        $loop->addTimer(0.001, function () use ($pending) {
-            $pending->cancel();
-        });
-
-        $pending->then($this->expectCallableNever(), $this->expectCallableOnce());
-
-        $loop->run();
-    }
 }
diff --git a/tests/TcpConnectorTest.php b/tests/TcpConnectorTest.php
@@ -24,6 +24,24 @@ public function connectionToEmptyPortShouldFail()
         $loop->run();
     }
 
+    /** @test */
+    public function connectionToTcpServerShouldAddResourceToLoop()
+    {
+        $loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();
+        $connector = new TcpConnector($loop);
+
+        $server = new TcpServer(0, $loop);
+
+        $valid = false;
+        $loop->expects($this->once())->method('addWriteStream')->with($this->callback(function ($arg) use (&$valid) {
+            $valid = is_resource($arg);
+            return true;
+        }));
+        $connector->connect($server->getAddress());
+
+        $this->assertTrue($valid);
+    }
+
     /** @test */
     public function connectionToTcpServerShouldSucceed()
     {
@@ -196,6 +214,30 @@ public function connectionToInvalidSchemeShouldFailImmediately()
         );
     }
 
+    /** @test */
+    public function cancellingConnectionShouldRemoveResourceFromLoopAndCloseResource()
+    {
+        $loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();
+        $connector = new TcpConnector($loop);
+
+        $server = new TcpServer(0, $loop);
+
+        $loop->expects($this->once())->method('addWriteStream');
+        $promise = $connector->connect($server->getAddress());
+
+        $resource = null;
+        $valid = false;
+        $loop->expects($this->once())->method('removeWriteStream')->with($this->callback(function ($arg) use (&$resource, &$valid) {
+            $resource = $arg;
+            $valid = is_resource($arg);
+            return true;
+        }));
+        $promise->cancel();
+
+        $this->assertTrue($valid);
+        $this->assertFalse(is_resource($resource));
+    }
+
     /** @test */
     public function cancellingConnectionShouldRejectPromise()
     {