{{ message }}
Update test suite and report failed assertions#501
Merged
Conversation
Member
Author
clue
force-pushed
the
update-tests
branch
2 times, most recently
from
45ad7d0 to
808ca88
Compare
Member
Author
|
Small update: Updated now that https://github.com/reactphp/promise/releases/tag/v2.10.0 has been released. This PR is still awaiting 3 other releases linked above. |
clue
force-pushed
the
update-tests
branch
2 times, most recently
from
36c0b78 to
cd41192
Compare
Member
Author
|
Small update: Updated now that https://github.com/reactphp/event-loop/releases/tag/v1.4.0 has been released. This PR is now still awaiting 2 other releases linked above. |
Member
Author
|
Small update: Updated now that https://github.com/reactphp/socket/releases/tag/v1.13.0 has been released. This PR is now only awaiting the Stream component release linked above. |
clue
changed the title
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #491, #455, #450, reactphp/socket#299, reactphp/socket#300 and reactphp/event-loop#264.
Marking this as WIP because this is currently awaiting a number of releases. PRs reactphp/event-loop#264, reactphp/promise#241 and reactphp/stream#165 need to be released to fix PHP 8.2 compatibility for the test suite, plus reactphp/socket#299 for legacy HHVM. Additionally, PHP 8.1 and PHP 8.2 builds currently segfault, likely due to php/php-src#10496 which should be fixed in PHP 8.2.4 (tagged just yesterday, not yet available through shivammathur/setup-php). I'll make sure to update this PR once releases are available.[update 1: segfaults fixed with PHP 8.2.4 and PHP 8.1.17] [update 2: updated to all stable releases]