Add issue template for better orientation by SimonFrings · Pull Request #466 · reactphp/reactphp · GitHub
Skip to content

Add issue template for better orientation#466

Merged
WyriHaximus merged 1 commit into
reactphp:1.xfrom
SimonFrings:issue_template
Oct 4, 2022
Merged

Add issue template for better orientation#466
WyriHaximus merged 1 commit into
reactphp:1.xfrom
SimonFrings:issue_template

Conversation

@SimonFrings

@SimonFrings SimonFrings commented Sep 6, 2022

Copy link
Copy Markdown
Member

This pull request adds issue templates to this project.

grafik

With GitHub Discussions now activated on an organizational level (as discussed in #460), it makes sense to add issue templates to each ReactPHP repository to show users where they have to open up specific tickets:

  • New feature ideas and questions belong in ReactPHP discussions. GitHub discussions are more long-lived than issues, thus enabling better visibility for users.
  • We'll continue to use issues for bug reports. These bugs will be fixed at some point and then belong in closed issues. Additionally I won't add a bug template to reactphp/reactphp. IMO it makes no sense to report a bug in this repository. All bugs should be reported inside the related repo (http, socket, dns, etc.).
  • Security issues should be reported to us via email. It is important not to make security-related issues public before they have been fixed!

I will file pull requests to add issue templates for each ReactPHP repository. Repos like https://github.com/reactphp/branding or https://github.com/reactphp/.github won't receive them (makes no sense).

@nhedger

nhedger commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

@SimonFrings

Copy link
Copy Markdown
Member Author

@nhedger You're totally right, the only thing I'd have to do is to add the ISSUE_TEMPLATE folder to the .github folder inside reactphp/.github and it's done.

The downside is that EVERY project inside the ReactPHP organisation gets the same issue template. This may make sense for most projects (like dns, http, etc.) but not for something like reactphp/branding or reactphp/reactphp. I would instantly do this if GitHub had some kind of functionality to exclude specific repositories, but I didn't find anything similar.

In conclusion: I am willing to take the slightly longer road and do it for every repository individually (which means only to copy-paste at some point 😄). Just feels right ^^

@SimonFrings

Copy link
Copy Markdown
Member Author

@WyriHaximus WyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WyriHaximus WyriHaximus requested a review from clue September 14, 2022 20:59
Comment thread .github/ISSUE_TEMPLATE/config.yml Outdated
Comment thread .github/ISSUE_TEMPLATE/config.yml

@clue clue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thank you for the update, changes LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants