{{ message }}
Allow use of PSR-7 v2#545
Open
Crell wants to merge 2 commits into
Open
Conversation
Author
Member
It's a bit of a long story: friends-of-reactphp/mysql#205 |
Member
|
Just merged #543 that will resolve the segfault |
Author
|
Oh, that thing... |
Author
|
Hm, it's still locking psr/http-message 1.1, even on newer PHP versions that would support 2.0. I'm not sure why. |
|
|
5 tasks
Author
Well [expletive deleted]. That package appears to be abandoned. I don't know if switching to nyholm/psr7 (which is supported and solid) is viable, but this sounds like a larger problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PSR-7 v2 just adds types, which should be safe in virtually any circumstances. It does require PHP 7.2 or higher, but allowing either version should allow Composer to figure it out.
Without this, having React installed makes a project incompatible with any package that depends on PSR-7 v2, which is a non-small number.
(I haven't tried running this locally yet; I am assuming CI will indicate if there's an issue.)