Slightly more clear peer address resolvement#26
Conversation
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Thank you for looking into this 👍 While I agree that the current solution is far from ideal, I'm not sure the suggested change actually improves this much.
However, I vote 👎 for this change simply because this is a BC break given the API is currently protected and this is (unfortunately) something consumers could potentially rely on.
|
@WyriHaximus I don't see anything on the roadmap for this component at the moment, so I'm not sure a v2.0.0 is something that is due any time soon? This component is lacking documentation, so perhaps that's also what caused some of the confusion for people trying to make sense of the internal parameters. It's my understanding that some consumer facing documentation both as part of the class hierarchy and the README would help here 👍 |
3 participants
This came up during a chat in a private channel where there was some confusion about how
$peerwas populated. This PR fixes that be returning anarray()and pulling those into two variables again usinglist().