[RFC] Use arrays instead of iterable for multiple cache items by clue · Pull Request #37 · reactphp/cache · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions README.md
6 changes: 3 additions & 3 deletions src/ArrayCache.php
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public function delete($key)
return Promise\resolve(true);
}

public function getMultiple($keys, $default = null)
public function getMultiple(array $keys, $default = null)
{
$values = array();

Expand All @@ -126,7 +126,7 @@ public function getMultiple($keys, $default = null)
return Promise\all($values);
}

public function setMultiple($values, $ttl = null)
public function setMultiple(array $values, $ttl = null)
{
foreach ($values as $key => $value) {
$this->set($key, $value, $ttl);
Expand All @@ -135,7 +135,7 @@ public function setMultiple($values, $ttl = null)
return Promise\resolve(true);
}

public function deleteMultiple($keys)
public function deleteMultiple(array $keys)
{
foreach ($keys as $key) {
unset($this->data[$key], $this->expires[$key]);
Expand Down
45 changes: 24 additions & 21 deletions src/CacheInterface.php