Unskip lone surrogate string fixture by fallintoplace · Pull Request #36863 · react/react · GitHub
Skip to content

Unskip lone surrogate string fixture#36863

Open
fallintoplace wants to merge 1 commit into
react:mainfrom
fallintoplace:preserve-lone-surrogate-string-tests
Open

Unskip lone surrogate string fixture#36863
fallintoplace wants to merge 1 commit into
react:mainfrom
fallintoplace:preserve-lone-surrogate-string-tests

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

This unskips the lone-surrogate-string-values fixture for AST round-tripping and scope rename coverage.

The old TODO points at an SWC conversion helper that is no longer present in this checkout. The fixture now passes through the existing JsString marker/code-unit-preserving path, so it should be covered by the tests instead of staying listed as a known failure.

How I tested

  • cargo test -p react_compiler_ast round_trip_all_fixtures
  • cargo test -p react_compiler_ast scope_resolution_rename
  • cargo test -p react_compiler_diagnostics js_string
  • cargo fmt --check
  • git diff --check

@meta-cla meta-cla Bot added the CLA Signed label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant