{{ message }}
Repository navigation
ScriptRuntimeApiImpl wasm compatibility fixed - #601
Open
gleblebedev wants to merge 5 commits into
Open
gleblebedev wants to merge 5 commits into
gleblebedev wants to merge 5 commits into
Conversation
rokups
reviewed
Aug 21, 2023
Member
There was a problem hiding this comment.
Doesn't this call throw an exception? Strings default to null, so in wasm they wont be set and this call tries to use ProgramDirectory. Either InstallAssemblyLoader needs to be not called or it needs to be modified to correctly work on wasm. I have no idea if we can have multiple C# DLLs on wasm platform and whether loading a DLL dynamically makes sense.
Contributor
Author
There was a problem hiding this comment.
It throws exception if there is no check. Also I didn't find any code that reads the field...
Member
There was a problem hiding this comment.
Like i said InstallAssemblyLoader tries to use ProgramDirectory so there would be an exception whenever ScriptRuntimeApiImpl is constructed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScriptRuntimeApiImpl type failed to initialize when running in web assembly because there is no assembly available there.