refactor: remove REST endpoint from SDK and admin config by rsbh · Pull Request #1529 · raystack/frontier · GitHub
Skip to content

refactor: remove REST endpoint from SDK and admin config#1529

Merged
rsbh merged 3 commits into
mainfrom
chore_cleanup_rest_client
Apr 10, 2026
Merged

refactor: remove REST endpoint from SDK and admin config#1529
rsbh merged 3 commits into
mainfrom
chore_cleanup_rest_client

Conversation

@rsbh

@rsbh rsbh commented Apr 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove endpoint from FrontierClientOptions in SDK (both shared/types.ts and legacy src/types.ts)
  • Remove NEXT_PUBLIC_FRONTIER_URL from admin config and turbo.json
  • Admin config now uses only connectEndpoint (NEXT_PUBLIC_FRONTIER_CONNECT_URL)
  • Remove legacy duplicate FrontierClientOptions, FrontierProviderProps, InitialState from sdk/src/types.ts

Test plan

  • Build passes (no new errors)
  • Lint passes on changed files

🤖 Generated with Claude Code

rsbh and others added 3 commits April 10, 2026 11:59
@rsbh @claude
refactor(sdk): remove endpoint from FrontierClientOptions
2fdf1f5 
Remove legacy REST endpoint field from FrontierClientOptions as all
network calls now go through connect-rpc. Also remove duplicate
FrontierClientOptions, FrontierProviderProps and InitialState from
sdk/src/types.ts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rsbh @claude
refactor(admin): remove REST endpoint from frontier config
dc8fe82 
Remove NEXT_PUBLIC_FRONTIER_URL and use only connect endpoint
(NEXT_PUBLIC_FRONTIER_CONNECT_URL) for all RPC calls.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rsbh @claude
chore: remove unused NEXT_PUBLIC_FRONTIER_URL from turbo.json
eb821ee 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5e112d7a-227a-4fe5-a486-5065e4868e21

📥 Commits

Reviewing files that changed from the base of the PR and between 0ffcf64 and eb821ee.

📒 Files selected for processing (5)
  • web/apps/admin/src/configs/frontier.tsx
  • web/sdk/react/contexts/FrontierContext.tsx
  • web/sdk/shared/types.ts
  • web/sdk/src/types.ts
  • web/turbo.json
💤 Files with no reviewable changes (4)
  • web/sdk/shared/types.ts
  • web/sdk/react/contexts/FrontierContext.tsx
  • web/turbo.json
  • web/sdk/src/types.ts
📝 Walkthrough

Summary by CodeRabbit

  • Breaking Changes
    • Endpoint configuration structure updated: the new connectEndpoint property consolidates what was previously split between endpoint and frontierEndpoint properties. Update your configuration accordingly.
    • The endpoint field is no longer required when configuring client options.

Walkthrough

The pull request removes the legacy endpoint property from Frontier configuration across the SDK and admin layers. Changes consolidate configuration to use only connectEndpoint, remove the endpoint field from type definitions and contexts, and update environment variable references in build configuration.

Changes

Cohort / File(s) Summary
Configuration changes
web/apps/admin/src/configs/frontier.tsx		 Refactored config builder to derive connectEndpoint from NEXT_PUBLIC_FRONTIER_CONNECT_URL (defaulting to "/frontier-connect") and removed the previously returned endpoint and frontierEndpoint properties.
Type definitions
web/sdk/src/types.ts, web/sdk/shared/types.ts		 Removed endpoint: string property from FrontierClientOptions interface; additionally removed exported InitialState and FrontierProviderProps type declarations and React import from web/sdk/src/types.ts.
Context provider
web/sdk/react/contexts/FrontierContext.tsx		 Removed the endpoint: 'http://localhost:8080' default value from defaultConfig, eliminating fallback endpoint supply during config composition.
Build configuration
web/turbo.json		 Removed "NEXT_PUBLIC_FRONTIER_URL" from the globalEnv list, retaining only "FRONTIER_API_URL", "FRONTIER_CONNECTRPC_URL", and "NEXT_PUBLIC_FRONTIER_CONNECT_URL".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • rohanchkrabrty
  • paanSinghCoder
  • rohilsurana

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls

coveralls commented Apr 10, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 24231766259

Coverage remained the same at 41.328%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats

Coverage Status
Relevant Lines: 36426
Covered Lines: 15054
Line Coverage: 41.33%
Coverage Strength: 11.88 hits per line
💛 - Coveralls

@rsbh rsbh merged commit d9ea0d3 into main Apr 10, 2026
8 checks passed
@rsbh rsbh deleted the chore_cleanup_rest_client branch April 10, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paanSinghCoder paanSinghCoder paanSinghCoder approved these changes
@rohanchkrabrty rohanchkrabrty Awaiting requested review from rohanchkrabrty

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rsbh @coveralls @paanSinghCoder