fix(gui): apply titles from Qt Designer files by jay23606 · Pull Request #9651 · randovania/randovania · GitHub
Skip to content

fix(gui): apply titles from Qt Designer files - #9651

Merged
ThanatosGit merged 3 commits into
randovania:mainfrom
jay23606:fix/foldable-ui-title-property
Oct 12, 2026
Merged

ThanatosGit merged 3 commits into
randovania:mainfrom
jay23606:fix/foldable-ui-title-property

Conversation

@jay23606

@jay23606 jay23606 commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Qt Designer file-defined Foldable titles and folded state were being applied again in the Prime 1 and Prime 2 dialogs because the widget properties were not readable through Qt's property system.

Changes

  • Make both title and folded Qt properties readable while preserving their setters.
  • Remove the duplicate title and folded assignments from the Prime 1 and Prime 2 dialogs; the values now come from their .ui files.
  • Use the existing skip_qtbot fixture pattern for property tests. The developer-only change has no changelog entry, as requested in review.

Relates to #9217.

Validation

  • Regression: the test_foldable.py cases fail on clean main (3 failures) and pass on this branch.
  • Foldable and Prime 1/Prime 2 dialog tests: 18 passed after removing the workarounds.
  • Ruff check and format on all six changed files passed; git diff --check passed.

Make the title Qt property readable so QObject.setProperty dispatches the setter used by generated UI code. Add a regression test and changelog entry.

Issue: #9217

@ThanatosGit ThanatosGit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idc that this was done by an LLM, but if it solves the problem, it should also eliminate the workaround that has been used to get around the problem so far in the existing files.

Comment thread randovania/gui/widgets/foldable.py
Comment thread test/gui/lib/test_foldable.py Outdated
Comment thread CHANGELOG.md Outdated
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

@ThanatosGit
ThanatosGit added this pull request to the merge queue Oct 12, 2026
Merged via the queue into randovania:main with commit ecf1b5d Oct 12, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants