{{ message }}
BigQuery Catalog#1
Open
rambleraptor wants to merge 8 commits into
Open
Conversation
rambleraptor
changed the title
.vscode folder to .gitignore (apache#2053)
talatuyarer
reviewed
Jun 5, 2025
rambleraptor
force-pushed
the
metadata_store
branch
2 times, most recently
from
c5adc49 to
3c94c83
Compare
talatuyarer
reviewed
Jun 5, 2025
talatuyarer
left a comment
talatuyarer
left a comment
There was a problem hiding this comment.
I did not see anyissue. I believe lets get the community's comments
There was a problem hiding this comment.
You may want to filter non iceberg tables by a configuration
| raise NoSuchNamespaceError(f"Namespace {namespace} not found") from e | ||
| return {} | ||
|
|
||
| def update_namespace_properties( |
There was a problem hiding this comment.
In Java Catalog interface does not have update properties but set properties also update them. Is this function python has ?
There was a problem hiding this comment.
Are you going to implement retry for retrialable errors or bigquery library is already handle that ?
rambleraptor
force-pushed
the
metadata_store
branch
2 times, most recently
from
e8adf49 to
87e0734
Compare
rambleraptor
force-pushed
the
metadata_store
branch
from
87e0734 to
f2ac9dd
Compare
rambleraptor
force-pushed
the
metadata_store
branch
3 times, most recently
from
c61838f to
706ab04
Compare
rambleraptor
force-pushed
the
metadata_store
branch
2 times, most recently
from
4c266a8 to
af8afa6
Compare
rambleraptor
force-pushed
the
metadata_store
branch
from
af8afa6 to
e01510b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
VSCode places all of its files in a folder now. We should add that
folder to gitignore in the same way we added the original files.
Are these changes tested?
No tests necessary.
Are there any user-facing changes?
None.
Rationale for this change
Are these changes tested?
Are there any user-facing changes?
Rationale for this change
VSCode places all of its files in a folder now. We should add that
folder to gitignore in the same way we added the original files.
Are these changes tested?
No tests necessary.
Are there any user-facing changes?
None.