{{ message }}
Repository navigation
Test ContentDisposition.format class method - #57546
Merged
rafaelfranca merged 1 commit intoJun 2, 2026
Merged
Conversation
ActionDispatch::Http::ContentDisposition.format is the public shortcut that builds the header string (used by data streaming and ActiveStorage), but every test built an instance and called #to_s directly. The class method itself was untested. Add coverage for .format with and without a filename.
rafaelfranca
added a commit
to matthewbjones/rails
that referenced
this pull request
Jun 2, 2026
…n-format Test ContentDisposition.format class method
rafaelfranca
added a commit
to matthewbjones/rails
that referenced
this pull request
Jun 2, 2026
…n-format Test ContentDisposition.format class method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActionDispatch::Http::ContentDisposition.formatis the public shortcut that builds the header string (used by data streaming and ActiveStorage), but every existing test constructed an instance and called#to_sdirectly — the class method itself was never exercised.This adds coverage for
.formatwith and without a filename. No production code changes — test-only.