{{ message }}
fix: basic repair context-menu script broken#745
Merged
Conversation
quoid
approved these changes
Oct 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #743
In old Safari
browser.menus.removejust failed silently for non-existent menu item, but in the latest version it rejects the promise, causes failed functional due to unhandled throw.userscripts/src/ext/background/main.js
Lines 201 to 204 in bca043a
Since all menu items are actually deleted every time,
sessionStoragerelated logic is not necessary. So simply delete it.Paths ending in
/corresponding to different Match patterns are expected and can be avoided at the user level. There no need to handle it at the extension level, so the relevant logic is deleted.Anyway, it's just a simple fix to get it basically working again.
But this feature needs to be completely redesigned and refactored.