nsurl is actually weird, i think http://example.com/dir/?query will have path of /dir?query

current fix will change it to /dir?query/?

@esterTion Really? I didn't reproduce that. But I can't have tested it on a really old system.

If the path has a trailing slash, it is stripped. https://developer.apple.com/documentation/foundation/nsurl/1408809-path

Actually looking at the documentation for Swift URL, it doesn't mention this at all, and it doesn't explicitly mention that it uses NSURL internally.
https://developer.apple.com/documentation/foundation/url/1779812-path

We're not using NSURL but just Swift URL, which is why I didn't notice this in the first place.

And I remember doing tests for both code paths that passed, I don't know why it's failing now.

nsurl is actually weird, i think http://example.com/dir/?query will have path of /dir?query

@esterTion I just tested and neither NSURL nor URL can reproduce this. Of course, I still can't test it in a really old OS.

import Foundation

let nsurl = NSURL(string: "http://example.com/dir/?query")!
let url = URL(string: "http://example.com/dir/?query")!

print(nsurl.path)
print(url.path)

sry posted on wrong thread

#694 (comment)

This is on macOS 10.15.3

I now think this should be considered a platform bug

@esterTion

Where is your breakpoint? In the match(_:_:) func?

Then what you see may be the path that has been processed by us and is only used for subsequent matching.

Please try running just the code I posted above in the Playground (outside the project).

Where is your breakpoint? In the match(::) func?

Oh it is! I thought that was from URL, url.path itself is indeed correct (except for "eating" the slash)