{{ message }}
Only lower if clean_key is instance of str#504
Merged
Conversation
Closed
Contributor
Author
Member
|
@vmatt Thanks for making the PR! |
Contributor
Author
|
@seperman, No worries, thanks for the feedback, I removed black formatting. |
Member
|
Thanks @vmatt ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #504 +/- ##
=======================================
Coverage 96.70% 96.70%
=======================================
Files 14 14
Lines 3946 3946
=======================================
Hits 3816 3816
Misses 130 130 ☔ View full report in Codecov by Sentry. |
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix AttributeError when group_by key is None with ignore_string_case
Related Issue
Fixes #503
Description
This PR fixes a bug where using
group_bywith a nullable key raises an AttributeError whenignore_string_case=True. The error occurs because the code attempts to call.lower()on None values.Changes
diff.pyto check if the key is a string before applying.lower()isinstance(clean_key, str)to safely handle None valuestests/test_diff_text.py, @seperman let me know if it's an issue and I should revert.Before
After
Testing
Added test case:
Checklist