Arm backend: Add TOSA binary op visitors by SaoirseARM · Pull Request #20479 · pytorch/executorch · GitHub
Skip to content

Arm backend: Add TOSA binary op visitors#20479

Open
SaoirseARM wants to merge 3 commits into
pytorch:mainfrom
SaoirseARM:toupstream/bin_node
Open

Arm backend: Add TOSA binary op visitors#20479
SaoirseARM wants to merge 3 commits into
pytorch:mainfrom
SaoirseARM:toupstream/bin_node

Conversation

@SaoirseARM

@SaoirseARM SaoirseARM commented Jun 24, 2026 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Running the cast pass first normalizes constant buffers while the graph is still Edge ATen, so ExirToTosaPass only sees int32 buffer metadata and emits TOSA-compatible ops.
  • Small refactor of ExirToTosaPass

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@SaoirseARM
Arm backend: Add TOSA binary op visitors
aa0055f 
- Run ExirToTosaPass after int64 cleanup.
- Small refactor of ExirToTosaPass

Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
@SaoirseARM SaoirseARM requested a review from digantdesai as a code owner June 24, 2026 08:20
@pytorch-bot

pytorch-bot Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jun 24, 2026
@SaoirseARM

SaoirseARM commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM

SaoirseARM commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot Bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jun 24, 2026
@SaoirseARM

SaoirseARM commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot Bot added the release notes: arm Changes to the ARM backend delegate label Jun 24, 2026
zingo
zingo approved these changes Jun 24, 2026
View reviewed changes

@zingo zingo left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge if tests are OK, just make sure buck2 stuff don't need to be updated. You can just ask codex/claude

@zingo

zingo commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes
@oscarandersson8218 oscarandersson8218 Awaiting requested review from oscarandersson8218
@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SaoirseARM @zingo @Erik-Lundell